Merged
Conversation
jbeder
approved these changes
Feb 18, 2026
Contributor
Author
|
@jbeder you are super fast! thank you! |
|
Wow! Thay was fast! Thanks guys! |
This was referenced Feb 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes skipping of empty documents and Issue #1405.
First Issue
A stream of multiple yaml documents can be separated by
---indicating starts of a new document and/or...indicating end of a document.So the following stream should produce 3 empty documents.
Currently yaml-cpp skips over empty documents at the end, so it falsely only produces a single empty document.
Second Issue
The case of
[foo]_barproduces multiple documents. The first one just containing the sequence[foo]. The second one containing the scalar_bar.This happens because it is missing to check if after a document are any unexpected tokens left in the stream.
Changes of this PR
This PR fixes both issue, the commits do the following:
1: add tests to check correct parsing of empty documents (fails)
2: fixes skipping of empty documents
3: add tests for
[foo]_bar(fails)4: fixes the newly added
[foo]_barcase.