Fix Advapi32#RegisterServiceCtrlHandler using wrong Handler type#1722
Open
dbwiddis wants to merge 1 commit intojava-native-access:masterfrom
Open
Fix Advapi32#RegisterServiceCtrlHandler using wrong Handler type#1722dbwiddis wants to merge 1 commit intojava-native-access:masterfrom
dbwiddis wants to merge 1 commit intojava-native-access:masterfrom
Conversation
Closes java-native-access#1510 The lpHandlerProc parameter resolved to Library.Handler (an InvocationHandler) instead of Winsvc.Handler (a StdCallCallback). Add the missing import for Winsvc.Handler.
matthiasblaesing
requested changes
May 10, 2026
Member
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
This is not enough. With javap you can see that the result of this change is not the desired one. I get:
matthias@enterprise:~/src/jnalib/contrib/platform/build/classes/com/sun/jna/platform/win32$ javap Advapi32.class | grep RegisterServiceCtrlHandler
public abstract com.sun.jna.platform.win32.Winsvc$SERVICE_STATUS_HANDLE RegisterServiceCtrlHandler(java.lang.String, com.sun.jna.Library$Handler);
public abstract com.sun.jna.platform.win32.Winsvc$SERVICE_STATUS_HANDLE RegisterServiceCtrlHandlerEx(java.lang.String, com.sun.jna.platform.win32.Winsvc$HandlerEx, com.sun.jna.Pointer);
matthias@enterprise:~/src/jnalib/contrib/platform/build/classes/com/sun/jna/platform/win32$
The class provided by the implemented interface gets priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lpHandlerProcparameter ofRegisterServiceCtrlHandlerresolved tocom.sun.jna.Library.Handler(anInvocationHandler) instead of the correctWinsvc.Handler(aStdCallCallback). The import forWinsvc.Handlerwas missing whileWinsvc.HandlerExwas imported.The javadoc already correctly referenced
Winsvc.Handlerbut the actual type resolution was wrong.Note: @matthiasblaesing observed that
RegisterServiceCtrlHandlerhas runtime issues when called from non-C code, andRegisterServiceCtrlHandlerEx(already correctly bound) is the recommended successor. This PR fixes the type signature for correctness regardless.Closes #1510