net - chore: upgrading undici to 7.22.0#1589
Conversation
Summary of ChangesHello @jaredwray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on routine dependency maintenance by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades undici to version 7.22.0 and @types/http-cache-semantics to 4.2.0. The changes in packages/net/package.json and pnpm-lock.yaml are correct for this dependency upgrade.
While reviewing the related code, I identified a potential bug in packages/net/src/index.ts. In the get method, the logic at lines 242-243 incorrectly disables caching if the caching option is set to true, contrary to the documentation. The condition if (options?.caching !== undefined) should likely be if (options?.caching === false) to align with the documented behavior and the implementation of other methods like head. As this is outside the files changed in this PR, I recommend addressing it in a separate pull request.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2447 2447
Branches 545 544 -1
=========================================
Hits 2447 2447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
net - chore: upgrading undici to 7.22.0