Potential fix for 1 code quality finding#3686
Draft
ann0see wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
ann0see
commented
May 11, 2026
| std::mutex queue_mutex; | ||
| std::condition_variable condition; | ||
| bool stop; | ||
| bool stop = false; |
Member
There was a problem hiding this comment.
After some thought, I've concluded that it is because CThreadPool has two constructors:
CThreadPool() = defaultCThreadPool(size_t)
and only thesize_tversion has a constructor initialisation forstop(false), a few lines further down. The default constructor doesn't, and therefore if that constructor were used,stopwould start uninitialised.
In fact, it would appear that in the code, the CThreadPool constructor is only ever called with the size_t argument, in server.cpp.
So in that case, instead of the above in-class initialisation, I would remove the default constructor declaration and check that the code still compiles (it should, unless I've overlooked something).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 1/2 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.
Not yet reviewed. We may want to check if this is a valid finding even.