Skip to content

Check for translation missing accelerator keys#3635

Open
softins wants to merge 1 commit intojamulussoftware:mainfrom
softins:checkkeys-show-missing
Open

Check for translation missing accelerator keys#3635
softins wants to merge 1 commit intojamulussoftware:mainfrom
softins:checkkeys-show-missing

Conversation

@softins
Copy link
Member

@softins softins commented Mar 8, 2026

Short description of changes

Adds a check to tools/checkkeys.pl to display a warning if an original English string contains an &accelerator key and the corresponding translation does not.

CHANGELOG: Tools: Updated checkkeys.pl to flag missing accelerator key in translation.

Context: Fixes an issue?

Just a useful check I thought of when reviewing #3620 and noticed a translation had not included an accelerator key, when there was one in the English original. This is the output for the current tree of that PR:

Language: de_DE
Language: es_ES
Language: fr_FR
Language: it_IT
Language: ja_JP
Language: ko_KR
Language: nb_NO
Language: nl_NL
Language: pl_PL

*** TRANSLATION MISSING ACCELERATOR KEY ***
Original: Clear &All Stored Solo and Mute Settings
Translation: Wyczyść wszystkie ustawienia solo/wycissz

Language: pt_BR
Language: pt_PT
Language: ru_RU
Language: sk_SK
Language: sv_SE

*** TRANSLATION MISSING ACCELERATOR KEY ***
Original: Sort Users by Chann&el
Translation: Sortera användare efter kanal

*** TRANSLATION MISSING ACCELERATOR KEY ***
Original: P&rivacy policy...
Translation: Integritetspolicy...

Language: th
Language: zh_CN
......

So it flagged up a couple of other existing translations, in addition to the new one I noticed initially.

Does this change need documentation? What needs to be documented and how?

Not really.

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Just review.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins added this to the Release 3.12.0 milestone Mar 8, 2026
@softins softins added this to Tracking Mar 8, 2026
@softins softins added the tooling Changes to the automated build system label Mar 8, 2026
@github-project-automation github-project-automation bot moved this to Triage in Tracking Mar 8, 2026
@softins softins force-pushed the checkkeys-show-missing branch from 5ec65c2 to 982c054 Compare March 8, 2026 21:52
@softins softins self-assigned this Mar 8, 2026
@softins softins requested review from ann0see and pljones March 8, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Changes to the automated build system

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants