Add support for adding a displayName property for the returned Loadable component#226
Open
backyardcoder wants to merge 1 commit intojamiebuilds:masterfrom
backyardcoder:support-for-display-name
Open
Add support for adding a displayName property for the returned Loadable component#226backyardcoder wants to merge 1 commit intojamiebuilds:masterfrom backyardcoder:support-for-display-name
backyardcoder wants to merge 1 commit intojamiebuilds:masterfrom
backyardcoder:support-for-display-name
Conversation
Author
|
What do you think about adding this support, @jamiebuilds @tajo? |
|
It would be super cool to have this as part of the project. For a certain project, I am relying on the component displayName to help pick out certain components from children. Since we have moved to use react-loadable we have not been able to do this. |
Repository owner
deleted a comment from
ygs-code
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary reason to introduce this change is to provide a way to aid the testing of components that consumes a Loadable component.
For example:
With the help of
displayName, one can use a package likeproxyquireto set up the correct fake loader stub to return expected components.