Move all Shader Node related code and assets to Material Support module#402
Open
neph1 wants to merge 1 commit intojMonkeyEngine:masterfrom
Open
Move all Shader Node related code and assets to Material Support module#402neph1 wants to merge 1 commit intojMonkeyEngine:masterfrom
neph1 wants to merge 1 commit intojMonkeyEngine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intermediate step which may not be 100% complete yet. I'll use this PR to change icons in the Shader Editor as well.
I found it odd that these classes and icons were part of the "core", rather than "materialdefinition" package. Seemed like an oversight that no one bothered to fix.
If there's a good reason why it should be in core, let me know, and I'll close this PR.