Skip to content

Migrate to Junit5#2684

Open
8Keep wants to merge 3 commits intojMonkeyEngine:masterfrom
8Keep:junit5-migration
Open

Migrate to Junit5#2684
8Keep wants to merge 3 commits intojMonkeyEngine:masterfrom
8Keep:junit5-migration

Conversation

@8Keep
Copy link
Copy Markdown
Contributor

@8Keep 8Keep commented Apr 7, 2026

We still use junit 4. Trying to migrate to junit 5.

This is a bulky all in one PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's test suite from JUnit 4 to JUnit 5 (Jupiter). It updates the Gradle dependencies, including the addition of the JUnit BOM and platform launcher, and refactors numerous test files to use the new JUnit 5 annotations and assertion classes. A critical issue was identified regarding an invalid version for the JUnit BOM in the version catalog.

@8Keep 8Keep marked this pull request as draft April 7, 2026 00:45
@8Keep 8Keep force-pushed the junit5-migration branch from 5f268af to a07d8b9 Compare April 7, 2026 01:59
@8Keep
Copy link
Copy Markdown
Contributor Author

8Keep commented Apr 7, 2026

@richardTingle It looks like the screenshot changes are all minuscule changes, let me know if you disagree.

@8Keep 8Keep marked this pull request as ready for review April 7, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant