Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
There was a problem hiding this comment.
Code Review
This pull request migrates the project's test suite from JUnit 4 to JUnit 5 (Jupiter). It updates the Gradle dependencies, including the addition of the JUnit BOM and platform launcher, and refactors numerous test files to use the new JUnit 5 annotations and assertion classes. A critical issue was identified regarding an invalid version for the JUnit BOM in the version catalog.
|
@richardTingle It looks like the screenshot changes are all minuscule changes, let me know if you disagree. |
We still use junit 4. Trying to migrate to junit 5.
This is a bulky all in one PR.