feat: pass loader and version type to Modrinth version resolution#3832
Open
bestcodename wants to merge 3 commits intoitzg:masterfrom
Open
feat: pass loader and version type to Modrinth version resolution#3832bestcodename wants to merge 3 commits intoitzg:masterfrom
bestcodename wants to merge 3 commits intoitzg:masterfrom
Conversation
Owner
|
I'm so sorry that I forgot about this PR. Just to check, did you test with a couple of different mod loaders like Fabric, Paper, NeoForge? |
Author
|
im sorry but i didnt update the unit tests in the related PR yet |
Owner
|
Ah, now I remember that. No hurry at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates 'start-configuration' to pass server 'TYPE' and 'MODRINTH_PROJECTS_DEFAULT_VERSION_TYPE' to the version resolution command. Related to #3681