Skip to content

Merge objects from getVars plugin method #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nleush wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Merge objects from getVars plugin method #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f657c88
merge objects from `getVars` plugin method
nleush Apr 6, 2026
88de429
Merge branch 'dev' into feature/merge-vars
iparamonau Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,19 +944,42 @@
for(var key in r.data) {
var v = r.data[key];

// TODO: work with arrays?
if (v !== '' && v !== null && ((typeof v === 'string' && !/^\s+$/.test(v)) || typeof v === 'number' || typeof v === 'object')) {

// Check meta plugins order.
allResults.vars._sources = allResults.vars._sources || {};

var prevOrder = null, nextOrder = null, pluginId = allResults.vars._sources[key];
var prevOrder = null, nextOrder = null, prevPluginId = allResults.vars._sources[key];

if (pluginId && plugins[pluginId] && plugins[r.method.pluginId]) {
prevOrder = plugins[pluginId].order;
if (prevPluginId && plugins[prevPluginId] && plugins[r.method.pluginId]) {
prevOrder = plugins[prevPluginId].order;
nextOrder = plugins[r.method.pluginId].order;
}

if (!prevOrder || !nextOrder || prevOrder < nextOrder) {
var oldValue = allResults.vars[key];

var newValueOverrides = !prevOrder || !nextOrder || prevOrder < nextOrder;

if (typeof v === 'object' && typeof oldValue === 'object') {

if (newValueOverrides) {
// Override existing object.
Object.assign(oldValue, v);
} else {
// Reassign with old values on top.
allResults.vars[key] = Object.assign(v, oldValue);
}

if (!Array.isArray(allResults.vars._sources[key])) {
// Convert sources list to array.
allResults.vars._sources[key] = [allResults.vars._sources[key]];
}
allResults.vars._sources[key].push(r.method.pluginId);

} else if (newValueOverrides) {

// Assign new non object value.
allResults.vars[key] = v;
allResults.vars._sources[key] = r.method.pluginId;
}
Expand Down
Loading