Exercise 1: Add sock layout component#13
Open
bossepierre wants to merge 5 commits intoitenium-be:masterfrom
Open
Exercise 1: Add sock layout component#13bossepierre wants to merge 5 commits intoitenium-be:masterfrom
bossepierre wants to merge 5 commits intoitenium-be:masterfrom
Conversation
Laoujin
reviewed
May 31, 2024
| standalone: true, | ||
| imports: [], | ||
| templateUrl: './sock-layout.component.html', | ||
| styleUrl: './sock-layout.component.scss' |
Laoujin
reviewed
May 31, 2024
| styleUrl: './sock-layout.component.scss' | ||
| }) | ||
| export class SockLayoutComponent { | ||
| @Input() sockModel! : Sock; |
Member
There was a problem hiding this comment.
Is natuurlijk wat persoonlijke voorkeur en/of hangt af van project tot project maar ik zou niet expliciet Model toevoegen aan een input
Laoujin
reviewed
May 31, 2024
| </div> | ||
| </a> | ||
| </div> | ||
| <app-sock-layout [sockModel]="sock"></app-sock-layout> |
Member
There was a problem hiding this comment.
This is the Angular way, finegrained components!
Laoujin
reviewed
May 31, 2024
itenium-socks/src/app/app.config.ts
Outdated
| provideZoneChangeDetection({ eventCoalescing: true }), | ||
| provideRouter(routes), | ||
| provideHttpClient(withFetch()), | ||
| {provide: DEFAULT_CURRENCY_CODE, useValue: 'EUR' } |
Member
There was a problem hiding this comment.
Om het dan ook op z'n "Belgisch" te tonen, ook:
import { registerLocaleData } from '@angular/common';
import localeNlBe from '@angular/common/locales/nl-BE';
registerLocaleData(localeNlBe, 'nl-BE');
En:
{ provide: LOCALE_ID, useValue: 'nl-BE' }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise 1: Add sock layout component