feat: enforce strict BCP47 language tag validation#280
Merged
Conversation
go-playground/validator's bcp47_language_tag accepted 3-letter ISO 639-2 codes (ita, fra, deu) and POSIX underscore tags (en_GB, hr_HR), which are not valid BCP47. validators/bcp47.go is a local copy of go-playground/validator#1489 (not yet merged) and should be removed once that lands. Fix #47.
bfabio
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 52.43% 47.61% -4.83%
==========================================
Files 14 15 +1
Lines 967 1067 +100
==========================================
+ Hits 507 508 +1
- Misses 430 529 +99
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.