[P.6] copyedit: Move a comment for consistency, change "a" to "the", and fix a typo: "f" to "f2"#2288
Merged
hsutter merged 5 commits intoisocpp:masterfrom Dec 3, 2025
Merged
Conversation
A comment in a code example was intended to refer to a function named "f2", but the comment uses the name "f" instead, presumably because the code was copied from the previous example; this commit fixes the typo.
…isocpp#2288) This matches the way the previous, related code example is written, a fact you can observe more readily by reviewing the patch of this commit with larger context: git diff -U19 Specifically, the previous example looks like this: // bad: the number of elements is not passed to f() f(new int[n]);
While "a wrong number can be passed" makes sense (and there are perhaps good philosophical reasons to prefer it), I believe that the more natural way to say it in common English is "the wrong number can be passed"; thus, this commit changes "a" to "the" in the comment of a code example.
…and fix a typo: "f" to "f2" (isocpp#2288) This is a merge commit to bundle trivial changes: * [This Commit] |\ | * trivial: s/a/the/ | * trivial: Move a code comment (//...) to the line above the code | * trivial: s/f/f2/ |/ * d40a490
mfwitten
force-pushed
the
typos/0001-f2/latest
branch
from
292fc15 to
25c6708
Compare
mfwitten
changed the title
Contributor
Author
|
I force-pushed a new set of commits, so as to make 2 changes:
|
Contributor
|
Editors call: Thanks! |
Contributor
|
Note to editors: At first I was going to keep the comment on the same line as formatted originally, and then I saw that this change makes the formatting consistent with the immediately preceding example which also puts the comment on a separate line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a merge commit to bundle trivial changes: