Skip to content

Conversation

@Rektroth
Copy link

@Rektroth Rektroth commented Dec 31, 2025

Port to 1.21.11. Closes #514.

Removes the fixes for MC-22882 and MC-199467, as they were marked as resolved as of 1.21.11.

Includes the fix for armor stands rendering dark (from #509, closes #507) and the corrected description for MC-121903 (#511).

Potential issues:
This PR, like, actually sucks, because:

  • To get builds working, I had to update Loom, Gradle, and Modstitch. I have no idea if I did this the "proper" way.
  • The No-YACL screen may be broken - YACL appears to be pre-included, at least in the development environment, and I'm not sure how to disable this.
  • I especially had trouble with the fix for MC-237493. I don't like the solution I came up with, and I haven't tested it thoroughly.

@Rektroth Rektroth marked this pull request as ready for review December 31, 2025 18:24
@Rektroth Rektroth force-pushed the 1.21.11 branch 2 times, most recently from 7350341 to c694fc1 Compare January 2, 2026 01:34
@MicrocontrollersDev
Copy link
Contributor

Can't say I agree with the Overwrites for MC-61489, using a ModifyReturnValue with original + height / 3 seems like the easier approach. Or if we really don't want anyone else touching it, a WrapMethod, though not sure that's required.

Also TelemetryInfoScreenMixin could be a WrapOperation rather than a Redirect

Otherwise the rest looks fine, not that I've tested anything myself but I was in the process of porting when I saw this PR existed, and most of the changes line up exactly with mine. But I did not figure out MC-237493 so :)

@Rektroth
Copy link
Author

@MicrocontrollersDev I also imagine there may be an expression that would be preferable to use over specifying an ordinal, but if so I was unable to figure it out.

@Unique
T squidEntity;

@Inject(method = "extractRenderState(Lnet/minecraft/world/entity/animal/Squid;Lnet/minecraft/client/renderer/entity/state/SquidRenderState;F)V", at = @At("TAIL"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Inject(method = "extractRenderState(Lnet/minecraft/world/entity/animal/squid/Squid;Lnet/minecraft/client/renderer/entity/state/SquidRenderState;F)V", at = @At("TAIL"))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay don't know why this suggested change also looks weird? The target needs to be updated is all (animal/Squid -> animal/squid/Squid)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, figured it out. Weird I never got an error from this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's one I missed as well in my initial port. It only gives a missing target error warning when launching the game, and god knows how it launches in the first place

@MicrocontrollersDev
Copy link
Contributor

@MicrocontrollersDev I also imagine there may be an expression that would be preferable to use over specifying an ordinal, but if so I was unable to figure it out.

Gave my best shot at bypassing the ordinals. There's probably a nicer way to write this Expression but I just know how to write expressions, not how to write good expressions. Also, the original mixin didn't work for me since it tries to cast a Cycle button to a Checkbox, which maybe worked in 1.21.10 but in 1.21.11 made my screen blank whenever I opened the telemetry options button. So this replaces the checkbox button entirely.

@isXander
Copy link
Owner

I'm very annoyed with myself because I distinctly remember partially porting this myself but I cannot find it on any of my machines!!!

build.gradle.kts Outdated
- Generated by `./gradlew generatePatchedTable`
- Sourced from `${inputFile.name}`
- Generated $timestamp
- Generated now
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I was having trouble building:

* What went wrong:
Script compilation errors:

  Line 216:         val timestamp = `java.time`.LocalDateTime.now().format(`java.time.format`.DateTimeFormatter.ISO_DATE_TIME)
                                                ^ Unresolved reference 'LocalDateTime'.

  Line 216:         val timestamp = `java.time`.LocalDateTime.now().format(`java.time.format`.DateTimeFormatter.ISO_DATE_TIME)
                                                                                              ^ Unresolved reference 'DateTimeFormatter'.

This was my fix just so that I could build.

I've removed it.

@isXander isXander changed the base branch from 1.21.10 to 1.21.11 January 11, 2026 13:43
@isXander isXander merged commit bcce17f into isXander:1.21.11 Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.21.11 [Bug] Armor stands render entirely black (Fabric, 1.21.10)

4 participants