only store the parent header in parent_headers#660
Closed
minrk wants to merge 1 commit intoipython:masterfrom
Closed
only store the parent header in parent_headers#660minrk wants to merge 1 commit intoipython:masterfrom
minrk wants to merge 1 commit intoipython:masterfrom
Conversation
the old parent_header was actually the parent *message*, but we don't need to keep doing that
minrk
force-pushed
the
parent-header-header
branch
from
d70a39d to
45bdae5
Compare
Member
Author
|
Alternative here is to keep storing the full parent message and add a new |
Member
|
Thanks for this!
I don't have an opinion on this. Symmetric is nice... |
Member
Author
|
Symmetrical version in #661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the now-deprecated
_parent_headerwas actually the parent message, but we don't need to keep doing that.#657 makes
get_parent_headera public API, so let's be more precise about actually returning the header