crypto: Restrict conjugate() to degree-2 extension fields#1485
Open
crypto: Restrict conjugate() to degree-2 extension fields#1485
Conversation
The conjugate operation (negating the second coefficient) is only mathematically correct for degree-2 extensions. Add a requires clause to prevent misuse on degree-3+ types where it would produce incorrect results silently.
There was a problem hiding this comment.
Pull request overview
This PR prevents mathematically incorrect use of ExtFieldElem::conjugate() by restricting it to quadratic (degree-2) extension fields, where conjugation is defined as negating the second coefficient.
Changes:
- Add a C++20
requires(DEGREE == 2)constraint toExtFieldElem::conjugate(). - Simplify the conjugation implementation to directly return
(a, -b)for degree-2 elements. - Update the doc comment to explicitly document the degree-2 semantics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
- Coverage 96.79% 96.79% -0.01%
==========================================
Files 154 154
Lines 13932 13929 -3
Branches 3265 3264 -1
==========================================
- Hits 13486 13483 -3
Misses 306 306
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conjugate operation (negating the second coefficient) is only mathematically correct for degree-2 extensions. Add a requires clause to prevent misuse on degree-3+ types where it would produce incorrect results silently.