Add IPinfoLiteWrapper to support Lite API#99
Merged
silvanocerza merged 4 commits intomasterfrom Jun 20, 2025
Merged
Conversation
Contributor
|
@silvanocerza I fixed the problem with the old Confirming that tests are now passing in Github Actions. |
max-ipinfo
approved these changes
Jun 19, 2025
silvanocerza
deleted the
silvano/eng-283-add-lite-api-support-to-ipinfonode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like in ipinfo/python#110 I decided to create a separate class to call the Lite API as the returned object is different from the Core API.
The tests I wrote are different from the existing ones as they actually call the API and don't rely on the test app so I had to change the tests workflow for them to properly run.
We need to update the
IPINFO_TOKENsecret as it's causing CI to fail and is probably expired.