Conversation
just a precaution, since we still have TTL=0 for many DNSLink responses due to #329 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 59.75% 59.87% +0.12%
==========================================
Files 238 238
Lines 29999 30004 +5
==========================================
+ Hits 17926 17965 +39
+ Misses 10450 10426 -24
+ Partials 1623 1613 -10
|
lidel
commented
Jul 29, 2024
Member
Author
There was a problem hiding this comment.
Lgtm, we will likely refine cache-control across all response types, but this is useful fix of a hot path (dir listings on /ipfs should benefit from wider cache window).
Related spec clarification in ipfs/specs#480
Digression:
max-agebased on TTL for/ipns/{dnslink}is unrelated to this fix, but we may want to fix it sooner than later, as #329 (comment) impacts directory listings, and that is why this PR is limited to dir listings on/ipfs.- We are not married to the
stale-while-revalidatevalue on IPNS, could adjust if needed (mutable conformance tests only care aboutmax-age), but 1 month sounds more robust than a few days or a week, the intention is to avoid link rot, if http cache supports such wide window.
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
…pfs#643) * fix(gateway): Cache-Control header for UnixFS directories * fix: limit static cache-control to /ipfs just a precaution, since we still have TTL=0 for many DNSLink responses due to ipfs#329 (comment) --------- Co-authored-by: Joshua Noble <jnoble@filebase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from #639
/ipfsto not over-cache DNSLink websites with default resolver (due to TTL gap described in Gateway: Cache-Control, max-age=ttl, ETag for /ipns requests #329 (comment)