Skip to content

Set build time requirements #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cstamas merged 2 commits into from
Jan 20, 2026
Merged

Set build time requirements #267

cstamas merged 2 commits into from
Jan 20, 2026
+36 −5

Conversation

@cstamas
Copy link
Collaborator

@cstamas cstamas commented Jan 20, 2026 •
edited
Loading

As we agreed, keep build-time requirements on LTS tools:

Also document that this project classpath run time requirement is:

  • Java 11+

@cstamas
Set build time requirements
1aa3a26 
As we agreed, keep build-time requirements on LTS tools:
* Java 21+
* Maven 3.9.6 (see https://maveniverse.eu/blog/2026/01/15/maven-components-and-maximum-java-bytecode/)

Also document that this project classpath run time requirement is:
* Java 11+
@cstamas cstamas self-assigned this Jan 20, 2026
@cstamas cstamas mentioned this pull request Jan 20, 2026
Merged
@cstamas cstamas marked this pull request as ready for review January 20, 2026 22:32
@vorburger vorburger mentioned this pull request Jan 20, 2026
Open
vorburger
vorburger requested changes Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas wait, won't this mean that I could now contribute code that uses a Java 21 API, and it will pass green on CI, this get merged - even though we want to stick to Java 11 only?

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 20, 2026 •
edited
Loading

Nope: javac -release 11 makes sure Java 21 API is not available during compile (only 11 API is), you will get compilation error.

See https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

@vorburger
Copy link
Collaborator

vorburger commented Jan 20, 2026

Nope: javac -release 11 makes sure Java 21 API is not available during compile (only 11 API is), you will get compilation error.

See https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

Oh! I see. Cool! OK, I've only got about 20 years of catching up to do... 😂

@cstamas cstamas merged commit 9951638 into master Jan 20, 2026
1 check passed
@cstamas cstamas deleted the fix/java-21 branch January 20, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianopolous ianopolous ianopolous approved these changes

@vorburger vorburger vorburger approved these changes

Assignees

@cstamas cstamas

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cstamas @vorburger @ianopolous