Skip to content

Conversation

@cstamas
Copy link
Collaborator

@cstamas cstamas commented Jan 20, 2026

Changes:

  • use Wrapper and 3.9.12
  • make sure CI uses wrapper (we control Maven version not the GH action)
  • use release compiler flag instead of source/target to set 11 level
  • enable reproducible build

Changes:
* use Wrapper and 3.9.12
* make sure CI uses wrapper (we control Maven version not the GH action)
* use `release` compiler flag instead of `source`/`target` to set 11 level
* enable reproducible build
@cstamas cstamas marked this pull request as ready for review January 20, 2026 19:45
@ianopolous
Copy link
Collaborator

A nice bonus could be a test for, at least basic (time invariant), reproducible builds - build twice and check hash equality.

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 20, 2026

[cstamas@angeleyes java-ipfs-http-client (fix/lock-down-maven)]$ mvn artifact:check-buildplan
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------< com.github.ipfs:java-ipfs-http-client >----------------
[INFO] Building java-ipfs-http-client v1.4.5-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- artifact:3.6.1:check-buildplan (default-cli) @ java-ipfs-http-client ---
[INFO] No known issue in 6 plugins
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.394 s
[INFO] Finished at: 2026-01-20T21:00:55+01:00
[INFO] ------------------------------------------------------------------------
[cstamas@angeleyes java-ipfs-http-client (fix/lock-down-maven)]$ 

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 20, 2026

Once we are on central, I will register it with Reproducible Central and we will get reports like this:
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/njord/README.md

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 20, 2026

We can also jot down this:
https://gist.github.com/cstamas/1553f4fdb3f7a1a9ecf2f2fc9748c671

And later compare (hint: plugin prefix is eu.maveniverse.maven.plugins). See:

@cstamas cstamas merged commit 39c25e4 into master Jan 20, 2026
1 check passed
@cstamas cstamas deleted the fix/lock-down-maven branch January 20, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants