chore: Simplify project by removing the Ant-based build; Maven only is fine #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the project build system by removing the Ant-based build configuration and retaining only Maven for building and testing. The change removes legacy build infrastructure that was causing confusion, as mentioned in issue #253.
Changes:
- Removed Ant build configuration file (
build.xml) - Removed Ant build and test steps from the CI workflow
- Removed JAR dependencies from the
lib/directory that were used by the Ant build - Fixed trailing whitespace in the CI workflow file
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.xml | Complete removal of the Ant build configuration file |
| .github/workflows/ant.yml | Removed Ant build and test steps; retained Maven-based testing |
| lib/*.jar | Removed JAR dependencies (multibase, multiaddr, multihash, cid, junit, hamcrest) that were managed by Ant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Yep totally fine. |
Contributor
|
You should have also updated the readme file, because it still refers to Ant commands. Also, the CI workflow file should probably be renamed. |
Closed
manandbytes
reviewed
Jan 20, 2026
| - name: Install and run ipfs | ||
| run: ./install-run-ipfs.sh | ||
| - name: Build & run tests with Maven | ||
| run: mvn test |
Contributor
There was a problem hiding this comment.
should it enable batch mode with -B and run verify instead?
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by noticing the confusion on #253.
@cstamas I'm sure you're in favour of this... 🤣
@ianopolous would this be cool with you?