Open
Conversation
mxinden
reviewed
May 16, 2023
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks for the work! No high-level concerns from the libp2p side.
Comment on lines
19
to
25
| pub struct BitswapProtocol; | ||
|
|
||
| impl ProtocolName for BitswapProtocol { | ||
| fn protocol_name(&self) -> &[u8] { | ||
| b"/ipfs-embed/bitswap/1.0.0" | ||
| } | ||
| fn protocol_name(&self) -> &[u8] { | ||
| b"/ipfs-embed/bitswap/1.0.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
With the upcoming release, namely v0.52.0 you can use StreamProtocol here. See libp2p/rust-libp2p#3746.
rkuhn
requested changes
May 19, 2023
Contributor
rkuhn
left a comment
rkuhn
left a comment
There was a problem hiding this comment.
While I appreciate the upgrade, please refrain from gratuitous whitespace changes — this codebase uses four-space-indentation.
mxinden
reviewed
May 22, 2023
| multihash = { version = "0.17.0", default-features = false, features = ["blake3", "sha2"] } | ||
| libipld = { version = "0.16.0", default-features = false, features = ["dag-cbor"] } | ||
| libp2p = { version = "0.51.3", features = ["tcp", "noise", "yamux", "rsa", "async-std"] } | ||
| multihash = { version = "0.18", default-features = false, features = ["blake3", "sha2"] } |
There was a problem hiding this comment.
Note that rust-libp2p still uses multihash v0.17.0. See comment here https://github.com/ipfs-rust/libp2p-bitswap/pull/43/files#r1200305495.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update to use libp2p 0.51.3, as it is necessary for our recently upgraded project which is based on the latest version. To avoid breaking issues, I have updated the version to 0.26.0, as this may cause compatibility problems for projects depending on/using libp2p 0.50.0.