Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates IPC Toolkit’s default broad-phase collision detection implementation to use LBVH (as introduced in #188) and aligns the getting-started tutorial text with the new default.
Changes:
- Switch
make_default_broad_phase()to constructLBVHinstead ofHashGrid. - Update the getting-started tutorial to state that the default broad phase is now
LBVH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ipc/broad_phase/default_broad_phase.hpp |
Changes the default broad-phase factory to return LBVH. |
docs/source/tutorials/getting_started.rst |
Updates the tutorial’s broad-phase list to reflect LBVH as the default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 96.95% 96.96%
=======================================
Files 159 159
Lines 24666 24666
Branches 882 883 +1
=======================================
+ Hits 23916 23917 +1
+ Misses 750 749 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace has_*() checks with bvh.size() <= 1 so functions require at least two primitives for collision tests.
Description
Set the default broad phase to
LBVH.As shown in #188, the LBVH outperforms all other methods on a variety of scenes.
Type of change
Please delete options that are not relevant.