fix(icons): load icons when properties initialize#1490
Open
OS-jacobbell wants to merge 2 commits intomainfrom
Open
fix(icons): load icons when properties initialize#1490OS-jacobbell wants to merge 2 commits intomainfrom
OS-jacobbell wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A change to Stencil's task queueing caused component initialization events and render method to be called before Angular sets dynamic props. The
loadIconmethod is therefore called beforesrcis set in some cases. Instead of relying on Stencil and Angular events to happen in a specific relative order, use a new feature in Stencil to watch for initial values of icon-setting properties.Change Type
Rationale / Problems Fixed
Fixes issue: ionic-team/ionic-framework#30629
where dynamic properties were not applied to icons.
Tests or Reproductions
Minimal test project from issue: https://stackblitz.com/~/github.com/andrzejpindor/ionic-icon-bindings-regression-repro?file=src/app/app.component.ts