feat(tab): modular ionic migration and lazy-load specs#31115
Draft
thetaPC wants to merge 2 commits intoionic-modularfrom
Draft
feat(tab): modular ionic migration and lazy-load specs#31115thetaPC wants to merge 2 commits intoionic-modularfrom
thetaPC wants to merge 2 commits intoionic-modularfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
thetaPC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-tabretains a@virtualProp themeJSDoc annotation that is no longer appropriate after the Modular Ionic migration. Also no spec tests exist for the component's lazy-load behavior.What is the new behavior?
@virtualProp themefromion-tabattachComponentis only called once across multiplesetActive()calls, and documents the permanent-failure behavior when the delegate rejects on the first attemptDoes this introduce a breaking change?
Other information
Since I was already here, I added spec tests that would be beneficial.