refactor(content, modal): update prefix for internal safe area variable#31114
Open
refactor(content, modal): update prefix for internal safe area variable#31114
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
requested review from
ShaneK and
brandyscarney
and removed request for
brandyscarney
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
We've decided to use
internalas the prefix for internal CSS variables andionfor public variables. We recently introduced a new internal variable for the safe area that doesn't have the correct prefix.What is the new behavior?
--ion-content-safe-area-padding-bottomto--internal-content-safe-area-padding-bottomDoes this introduce a breaking change?
Other information
N/A