Skip to content

fix(segment): segment drag would set disabled segment button checked#31112

Merged
os-davidlourenco merged 1 commit intomainfrom
ROU-12690
May 6, 2026
Merged

fix(segment): segment drag would set disabled segment button checked#31112
os-davidlourenco merged 1 commit intomainfrom
ROU-12690

Conversation

@os-davidlourenco
Copy link
Copy Markdown
Contributor

@os-davidlourenco os-davidlourenco commented May 5, 2026

Issue number: resolves internal


What is the current behavior?

  • When the first segment is disabled and the last item is selected, if the user swipes the segment-view, the first segment-button gets checked even if it is disabled, and the view is presenting other segment-view.

What is the new behavior?

  • A validation was added to ensure that the segment-button can only be checked if it is not disabled

Does this introduce a breaking change?

  • Yes
  • No

@os-davidlourenco os-davidlourenco requested a review from a team as a code owner May 5, 2026 17:55
@os-davidlourenco os-davidlourenco requested a review from thetaPC May 5, 2026 17:55
@os-davidlourenco os-davidlourenco added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package type: bug a confirmed bug report labels May 5, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment May 5, 2026 6:03pm

Request Review

@github-actions github-actions Bot removed package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels May 5, 2026
Copy link
Copy Markdown
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@os-davidlourenco os-davidlourenco added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 44be424 May 6, 2026
75 of 96 checks passed
@os-davidlourenco os-davidlourenco deleted the ROU-12690 branch May 6, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants