-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(content): add recipe and tokens #31095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ionic-modular
Are you sure you want to change the base?
Changes from all commits
7afba1a
32d2fdb
57c3140
5983c3b
76a32dd
7646ae6
412806f
c8f817c
6a496be
2904ea8
ca169b0
6dd900b
ec21b54
ec39980
7b8d89c
5d7fb5f
68c7136
dab1803
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,7 +143,6 @@ | |
| flex-shrink: 2; | ||
| overscroll-behavior-y: contain; | ||
| overflow-y: auto; | ||
| -webkit-overflow-scrolling: touch; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| pointer-events: all; | ||
|
|
||
| background: var(--background); | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change was because I synced the padding between themes to be consistent. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,16 +9,33 @@ | |
| /> | ||
| <link href="../../../../../css/ionic.bundle.css" rel="stylesheet" /> | ||
| <link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||
| <script> | ||
| // Need to be called before loading Ionic else | ||
| // the scripts.js logic runs too early. | ||
| window.Ionic = { | ||
| config: { | ||
| customTheme: { | ||
| components: { | ||
| IonContent: { | ||
| background: '#dde2ef', | ||
| padding: { | ||
| start: '16px', | ||
| end: '16px', | ||
| top: '16px', | ||
| bottom: '16px', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| </script> | ||
| <script src="../../../../../scripts/testing/scripts.js"></script> | ||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
|
|
||
| <!-- Styles only for testing purposes to identify the card shape --> | ||
| <style> | ||
| ion-content { | ||
| --background: #dde2ef; | ||
| } | ||
|
|
||
| .container { | ||
| padding: 8px; | ||
| } | ||
|
|
@@ -33,7 +50,7 @@ | |
| </ion-toolbar> | ||
| </ion-header> | ||
|
|
||
| <ion-content class="ion-padding ion-text-center" id="content" no-bounce> | ||
| <ion-content class="ion-text-center" id="content" no-bounce> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the padding through the config since I already had to pass the background value there. Figured that I would keep it all in one place by adding the padding. |
||
| <h1>Default</h1> | ||
| <div id="default" class="container"> | ||
| <ion-card> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,14 +10,26 @@ | |
| /> | ||
| <link href="../../../../../css/ionic/bundle.ionic.css" rel="stylesheet" /> | ||
| <link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||
| <script> | ||
| // Need to be called before loading Ionic else | ||
| // the scripts.js logic runs too early. | ||
| window.Ionic = { | ||
| config: { | ||
| customTheme: { | ||
| components: { | ||
| IonContent: { | ||
| background: '#dde2ef', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| </script> | ||
| <script src="../../../../../scripts/testing/scripts.js"></script> | ||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
|
|
||
| <style> | ||
| ion-content { | ||
| --background: #dde2ef; | ||
| } | ||
| .ion-margin-top { | ||
| margin-top: 32px; | ||
| } | ||
|
|
@@ -32,7 +44,7 @@ | |
| </ion-toolbar> | ||
| </ion-header> | ||
|
|
||
| <ion-content class="ion-padding-space-400" id="content" no-bounce> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed the class because it wasn't set anywhere. |
||
| <ion-content id="content" no-bounce> | ||
| <h4>Preview options</h4> | ||
|
|
||
| <p> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change mimics exactly how we are loading themes in the
theme.tsfile.