fix(http): Fix throwing data URI requests on iOS

[frederikbosch]

Since Capacitor 8.0 data: requests throw because NSURLResponse is not a HTTPURLRepsonse

[theproducer]

Thanks @frederikbosch! Do you have a reproduction for this issue, or can it be seen in basically any minimal project that uses CapacitorHttp?

[frederikbosch]

@theproducer I don't at the moment. I have upgraded my app from 7 to 8 and I got crashes because of the forced casts. It might very well be that because of some other upgrades that I only now started with data: URI requests.

That data URIs fail can be proven quite easily by this SwiftFiddle.

Moreover, it is kind of documented behavior. The URLSession.dataTask method documentation says:

If you are making an HTTP or HTTPS request, the returned object is actually an HTTPURLResponse object.

And a data: URI request is not a HTTP request. But documentation is not clear what the response is if the request is not a HTTP(S) request, but apparently it is a NSURLResponse.

[frederikbosch]

@markemer Much better to unpack the response optional, I have updated the PR.

[theproducer]

You may need to rename NSURLResponse to URLResponse here as well.

[jcesarmobile]

Can you give a bit more information about what are you doing to get the crash?

Are you getting it while doing regular fetch/XHR calls with http plugin enabled?
Or are you calling the CapacitorHttp plugin API directly like CapacitorHttp.get({url: 'data:text/plain;base64,SGVsbG8='})?

If you are doing fetch/XHR calls and you get the crash, could you provide a sample app that reproduces the issue?
I've not been able to get the crash while doing that.

If you are doing CapacitorHttp plugin API calls to data urls, while it shouldn't crash, it shouldn't work neither. CapacitorHttp plugin is to avoid CORS problems, and all methods description include "make a Request to a server", so should only be used with http/https urls, not with data urls.
I've tested this and it makes the plugin crash on iOS, but on Android it returns an error saying data urls are not supported, iOS should also do this instead of crashing.