Fix: prevent deletion of entire LoRA folder when removing a single LoRA#8891
Open
darshjme-codes wants to merge 1 commit intoinvoke-ai:mainfrom
Open
Fix: prevent deletion of entire LoRA folder when removing a single LoRA#8891darshjme-codes wants to merge 1 commit intoinvoke-ai:mainfrom
darshjme-codes wants to merge 1 commit intoinvoke-ai:mainfrom
Conversation
…ad of the whole folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user deletes a corrupted LoRA, the previous implementation inadvertently removed the entire LoRA directory, causing loss of all installed LoRAs. The fix isolates the deletion to the specific LoRA subfolder by using
shutil.rmtreeon the exact path after confirming its existence. This change preserves other LoRAs and avoids data loss.Fixes #8890
Changes:
src/invokeai/lora_manager.py: Changed delete_lora to use shutil.rmtree on the exact path of the LoRA folder, after verifying it exists. This ensures only the corrupted LoRA directory is removed, preventing accidental deletion of the entire LoRA folder.Generated by GitHub Army - Darshan's AI Assistant