feat(functions)!: convert functions to New Arch / drop functions Old Arch#8874
Open
feat(functions)!: convert functions to New Arch / drop functions Old Arch#8874
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
force-pushed
the
@mikehardy/revert-functions-turbomodules-revert
branch
from
50f62fc to
454c7a8
Compare
…ons old architecture Revert "fix(functions): revert TurboModules implementation / restore old architecture compatibility" This reverts commit fb0787c. BREAKING CHANGE: you must enable new architecture to use the functions module All modules will be converted to new architecture soon, old architecture support is deprecated in general for react-native-firebase
… module requires this should ease the transition in general and fail-fast specifically for functions
This reverts commit 6b62131.
…r needed definitely was needed for react-native-macos 0.74 but no longer needed for later versions
I always attempt `yarn tests:macos:test` before remembering that platform should be `test-cover`. Adding `test` so it just works for time and there is no platform difference
mikehardy
force-pushed
the
@mikehardy/revert-functions-turbomodules-revert
branch
from
454c7a8 to
7dac2ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a re-application of the changes that were already working well in 23.8.4 but were inadvertently breaking
We do not intend to support both old and new architecture but dropping old architecture for a module is a breaking change, so we pulled it and will re-issue now as a major version
I have also added deprecation warnings for dropping old architecture in general, and throw an error if a new-arch module is loaded in an old-arch app to improve the DX and communication a bit
Related issues
Release Summary
It should generate a major version with the
!on the conventional commit tagChecklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Try this version in an old arch app to see the deprecation notice, and try functions to see an error
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter