refactor(messaging): migrate to TypeScript#8818
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "packages/ai/lib/types/polyfills.d.ts", | ||
| "packages/app-check/lib/index.d.ts", | ||
| "packages/app-check/lib/modular/index.d.ts", | ||
| "packages/app-distribution/lib/index.d.ts", | ||
| "packages/app-distribution/lib/modular/index.d.ts", | ||
| "packages/app/lib/internal/global.d.ts", | ||
| "packages/app/lib/internal/web/memidb/index.d.ts", | ||
| "packages/auth/lib/index.d.ts", | ||
| "packages/auth/lib/modular/index.d.ts", | ||
| "packages/crashlytics/lib/index.d.ts", | ||
| "packages/crashlytics/lib/modular/index.d.ts", | ||
| "packages/database/lib/index.d.ts", | ||
| "packages/database/lib/modular/index.d.ts", | ||
| "packages/database/lib/modular/query.d.ts", | ||
| "packages/database/lib/modular/transaction.d.ts", | ||
| "packages/firestore/lib/index.d.ts", | ||
| "packages/firestore/lib/modular/Bytes.d.ts", | ||
| "packages/firestore/lib/modular/FieldPath.d.ts", | ||
| "packages/firestore/lib/modular/FieldValue.d.ts", | ||
| "packages/firestore/lib/modular/GeoPoint.d.ts", | ||
| "packages/firestore/lib/modular/Timestamp.d.ts", | ||
| "packages/firestore/lib/modular/index.d.ts", | ||
| "packages/firestore/lib/modular/query.d.ts", | ||
| "packages/firestore/lib/modular/snapshot.d.ts", | ||
| "packages/in-app-messaging/lib/index.d.ts", | ||
| "packages/in-app-messaging/lib/modular/index.d.ts", | ||
| "packages/installations/lib/index.d.ts", | ||
| "packages/installations/lib/modular/index.d.ts", | ||
| "packages/ml/lib/index.d.ts", | ||
| "packages/ml/lib/modular/index.d.ts", | ||
| "packages/perf/lib/index.d.ts", | ||
| "packages/perf/lib/modular/index.d.ts", | ||
| "packages/remote-config/lib/index.d.ts", | ||
| "packages/remote-config/lib/modular/index.d.ts", | ||
| "packages/storage/lib/index.d.ts", | ||
| "packages/storage/lib/modular/index.d.ts", |
There was a problem hiding this comment.
@mikehardy - This was the solution to the jest fight I had on my hands yesterday. Selecting every type declaration file was the only way I could stop duplicate messaging type symbols from dist/ leaking into source for jest test runner. Even using globs for each package (not converted to TS) failed to stop it happening which I still don't understand.
These can be removed with each package that is moved over to TS.
There was a problem hiding this comment.
Ouch! But I trust you on the fight and it's results, and especially since it'll sunset out anyway, works for me. That much more incentive to get all the way to TS
Related: I don't see packages/firestore/lib/modular/VectorValue.d.ts in there, from #8739 - you'll likely want to add it as well after pulling main into this PR
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
did extending from a common tsconfig in packages/app not work out? Just curious
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
same question about abstracting common tsconfig boilerplate to packages/app and extending here as I had on the other ones - not sure if you answered already, but I didn't see it if so, sorry
specific mention that you'll likely need to add VectorValue.d.ts as well from the PR I just merged. That jest fight must have been annoying
2 participants
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter