You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I finally caught back up to recent schema changes. Here's a small batch of added allow_null annotations for nullable read_only fields.
I also removed the default value of '' because that's not a valid selection from the choices list (which was resulting in code generated from the schema failing to compile). As far as I've spotted the changes to parameter/parameter template don't result in changes to the UI.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.17%. Comparing base (70fcaa7) to head (d24950d). ⚠️ Report is 285 commits behind head on master.
WARN: diff exceeds the 1MB limit, truncating output...
The API diff comparison is failing here
No idea why: the entire diff fits on one screen for me when I run it locally. I just rebased to make sure I'm up to date with master and I'll look into it more if that fails again.
I found a tool that gives a browser-viewable version of the generated change log and it is indeed massive (in part because changes to parameters makes it report changes to everywhere parameters are available). I should have time this afternoon to figure out if this is valid or if I need to split my changes to make the diff easier to review.
Long story short: changing the schema for parameters (such as allowing updated_by_detail to be nullable) results in reported changes for every api that has a detail field that includes parameters.
I rebased to pick up the new api_version changes and reduced the scope of my changes to try to fit within the tool for easier review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally caught back up to recent schema changes. Here's a small batch of added
allow_nullannotations for nullableread_onlyfields.I also removed the default value of '' because that's not a valid selection from the choices list (which was resulting in code generated from the schema failing to compile). As far as I've spotted the changes to parameter/parameter template don't result in changes to the UI.