fix: v1.7.5 - fix routine scanner, update documentation#35
Open
hkimura-intersys wants to merge 4 commits intointersystems:mainfrom
Open
fix: v1.7.5 - fix routine scanner, update documentation#35hkimura-intersys wants to merge 4 commits intointersystems:mainfrom
hkimura-intersys wants to merge 4 commits intointersystems:mainfrom
Conversation
Moved compiler_header check to AFTER the core scanner runs, as it was eating tokens and causing errors for times where something was a statement without a header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Key Changes include:
Bug Explained
A bug was found in
v1.7.4where the compiled header check (in the routine scanner) incorrectly consumed all tags during its check. Then, once it reverted to the core scanner, the tag tokens were consumed, so it would error. So, if a file started as a procedure without a routine header or a compiled header, it would error.This was fixed by putting the compiled_header check after the core scanner runs. Additionally, the routine header check is now a part of the core scanner, which makes it so if a tag starts with an R, it won't get incorrectly consumed by the routine scanner first.
Fix and Testing
This is now fixed, and procedures are parsed correctly in the routine grammar:
The entire core test suite has also been added to the routine test suite now, so everything is checked.
All github workflows have passed as well:
