Unit tests no longer take an absurdly long time in a container#935
Merged
isc-pbarton merged 1 commit intomainfrom Mar 4, 2026
Merged
Unit tests no longer take an absurdly long time in a container#935isc-pbarton merged 1 commit intomainfrom
isc-pbarton merged 1 commit intomainfrom
Conversation
…ng an unnecessary copy of node_modules from the mount. now it does not.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 50.97% 50.91% -0.07%
==========================================
Files 23 23
Lines 3131 3131
==========================================
- Hits 1596 1594 -2
- Misses 1535 1537 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-dchui
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NameToInternalNameTest unit test used to take a really long time, but now it does not. This is part of creating a usable containerized development environment for Embedded Git.