Fix error reporting in checkPivots()#42
Open
nickpetrocelli wants to merge 1 commit intointersystems-community:masterfrom
Open
Fix error reporting in checkPivots()#42nickpetrocelli wants to merge 1 commit intointersystems-community:masterfrom
nickpetrocelli wants to merge 1 commit intointersystems-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when checkPivots() loops through pivot tables, it will $order to the next key before printing errors to the terminal. This will falsely attribute any errors reported to the next pivot in the list instead of the correct pivot.
This fixes this issue by moving the $order call to after the error check.
Testing: pulled this change into a local package installation and ran the method to check that it functions correctly.