Fix: Ensure mode=2up persists in iframe#1383
Open
Ankush1oo8 wants to merge 1 commit intointernetarchive:masterfrom
Open
Fix: Ensure mode=2up persists in iframe#1383Ankush1oo8 wants to merge 1 commit intointernetarchive:masterfrom
Ankush1oo8 wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Author
|
can any one check it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Fix for Issue #1311**
This PR ensures that the
mode=2upsetting is properly respected when the BookReader is embedded inside an iframe. Previously, the reader defaulted to1upmode despite the URL containingmode=2up.** Changes Made:**
✅ Updated
BookReader.jsto ensure that:mode=2up), or fromlocalStorageif previously set.mode=2upparameter.1up,2up,thumb) persists after refresh.localStoragefor mode preference.🛠 Testing Done:
2upmode.1up,2up,thumb) → Refreshed page, mode persisted.** Steps to Reproduce & Test:**
2upmode.1upmode → Refresh the page → It should remember the last selected mode.✅ Expected Outcome:
2upmode.