feat: add opt-in config to execute all redeem and replace requests #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
reviewed
Feb 13, 2023
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/execute-all
branch
from
7222e27 to
684b207
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/execute-all
branch
from
684b207 to
a79fb38
Compare
gregdhill
changed the title
sander2
requested changes
Jun 30, 2023
Member
sander2
left a comment
sander2
left a comment
There was a problem hiding this comment.
execute_open_requests also makes bitcoin transfers if they haven't been made already. So unless there is a check hidden somewhere, this will make vaults pay for other vault's redeems. While I wouldn't mind people doing that, I don't think it's the intention here haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
I have only modified the startup routine that collects all requests since any change to the listener service would be far more involved, this is fine because the Vault restarts every three hours anyway.
Closes #439