Skip to content

Conversation

@1kuko3
Copy link
Contributor

@1kuko3 1kuko3 commented May 14, 2025

props to @erickreutz 👑

@erickreutz
Copy link

@uddish can we get this merged please?

@Ganitzsh
Copy link

So close, yet so far. Would be awesome to have this merged 🙏

@loeck
Copy link

loeck commented May 14, 2025

If you want to apply this fix right away (huge thanks to @1kuko3 and @erickreutz ❤️), drop in this patch:

diff --git a/lib/commonjs/expo-plugins/index.js b/lib/commonjs/expo-plugins/index.js
index a2460b1e7587c59f8d51f26553440862ba9f6d8b..f443590ffb8a6d58de7a0a65f37df83e2a6a6969 100644
--- a/lib/commonjs/expo-plugins/index.js
+++ b/lib/commonjs/expo-plugins/index.js
@@ -46,7 +46,7 @@ const appDelegate = (_config, props) => (0, _configPlugins.withAppDelegate)(_con
   const isSwift = config.modResults.language === 'swift';
   stringContents = isSwift ? (0, _generateCode.mergeContents)({
     src: stringContents,
-    newSrc: 'import intercom_react_native.IntercomModule',
+    newSrc: 'import intercom_react_native',
     comment: '//',
     tag: 'Intercom header',
     anchor: /import Expo/,
diff --git a/lib/module/expo-plugins/index.js b/lib/module/expo-plugins/index.js
index 3d2006281ed87a436cb3f792ef22187992781f84..c10c50a2a47cb907482c5478942addae5bec823e 100644
--- a/lib/module/expo-plugins/index.js
+++ b/lib/module/expo-plugins/index.js
@@ -40,7 +40,7 @@ const appDelegate = (_config, props) => withAppDelegate(_config, config => {
   const isSwift = config.modResults.language === 'swift';
   stringContents = isSwift ? mergeContents({
     src: stringContents,
-    newSrc: 'import intercom_react_native.IntercomModule',
+    newSrc: 'import intercom_react_native',
     comment: '//',
     tag: 'Intercom header',
     anchor: /import Expo/,
diff --git a/src/expo-plugins/index.ts b/src/expo-plugins/index.ts
index b9725cf1c2715dbb671d7aaf4a63fee5cd33e4a8..4678818a61ffd458f0ce800396dc00ca53d164b1 100644
--- a/src/expo-plugins/index.ts
+++ b/src/expo-plugins/index.ts
@@ -100,7 +100,7 @@ const appDelegate: ConfigPlugin<IntercomPluginProps> = (_config, props) =>
     stringContents = isSwift
       ? mergeContents({
           src: stringContents,
-          newSrc: 'import intercom_react_native.IntercomModule',
+          newSrc: 'import intercom_react_native',
           comment: '//',
           tag: 'Intercom header',
           anchor: /import Expo/,

And in your package.json (using pnpm):

"pnpm": {
  "patchedDependencies": {
    "@intercom/intercom-react-native@8.4.0": "patches/@intercom__intercom-react-native@8.4.0.patch"
  }
}

Update: add lib/module and lib/commonjs files

@heshamnimri
Copy link

Pleaseeee approve and merge this is blocking given the new App store requirements

ITMS-90725: SDK version issue This app was built with the iOS 17.2 SDK. Starting April 24, 2025, all iOS and iPadOS apps must be built with the iOS 18 SDK or later, included in Xcode 16 or later, in order to be uploaded to App Store Connect or submitted for distribution.

https://expo.dev/blog/apple-sdk-minimum-requirements#using-xcode-16-with-eas-build

@heshamnimri
Copy link

@uddish uddish merged commit 0206e90 into intercom:main May 15, 2025
8 checks passed
@uddish
Copy link
Contributor

uddish commented May 15, 2025

Hey all 👋
Appreciate the help here.
@liutingdu is going to release a new react native version today.

@liutingdu
Copy link
Member

Thanks folks @1kuko3 @erickreutz ❤️

I've just shipped v8.5.0 to include this change.

Currently we are short of RN/Expo expertise on the team, so we really appreciate the community’s input here. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants