Skip to content

Conversation

@imSzukala
Copy link
Contributor

@imSzukala imSzukala commented Jan 29, 2025

  1. Reverts this PR: Bump the npm_and_yarn group across 2 directories with 2 updates #253
  2. Bumps RN version to 0.74
  3. Updates setup script

niamh-coleman
niamh-coleman previously approved these changes Jan 29, 2025
@imSzukala imSzukala marked this pull request as ready for review January 29, 2025 15:32
@liutingdu
Copy link
Member

is there a way to block future auto upgrades on this 🤔

@uddish
Copy link
Contributor

uddish commented Jan 30, 2025

@liutingdu
We could add a preinstall hook that won't let us upgrade the version.

If this seems too strict, maybe we can add a warning.

We can add an engine config in our package.json for this

"engines": {
  "react-native": "0.74.0"
}

niamh-coleman
niamh-coleman previously approved these changes Jan 30, 2025
@imSzukala imSzukala changed the title Bump react native version to 0.74 Bump react native version to 0.74.7 Jan 30, 2025
@imSzukala imSzukala force-pushed the irena/bump-rn-version branch from ee98915 to 8e3f109 Compare January 30, 2025 14:15
@imSzukala imSzukala changed the title Bump react native version to 0.74.7 Bump react native version to 0.74 Jan 30, 2025
@imSzukala imSzukala merged commit 6273571 into main Jan 30, 2025
6 checks passed
@imSzukala imSzukala deleted the irena/bump-rn-version branch January 30, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants