Fix null reference error when filtering providers by language pairs#64
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Fix null reference error when filtering providers by language pairs#64devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
When routing is disabled and a provider is selected, the ProviderSupportsPair method was calling .Any() on potentially null Pairs and Symmetric arrays, causing 'Value can't be null. Parameter source' error. Added null checks before calling LINQ methods on provider.Pairs and provider.Symmetric arrays. Co-Authored-By: Vladimir Popinov <Vladimir.popinov@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "Value can't be null. Parameter source" error that occurs when configuring the Trados plugin with "Routing as Disabled" and selecting any provider.
Root cause: The
ProviderSupportsPairmethod was calling.Any()onprovider.Pairsandprovider.Symmetricarrays without null checks. Some providers may have null values for these arrays, causing anArgumentNullExceptionwhen LINQ methods are called on them.Fix: Added null checks before calling LINQ methods on these potentially null arrays.
Review & Testing Checklist for Human
Notes
PairsandSymmetricare null: the method now returnsfalse(provider doesn't support the pair) instead of throwing an exception. This should be the correct behavior as providers without language pair data shouldn't match any specific language pair filter.Link to Devin run: https://app.devin.ai/sessions/285b1ea5427e4f9da6c5e25c65367475
Requested by: Vladimir Popinov (@Xapgkop4uk)
Note
Fixes a null reference error during provider filtering.
ProviderSupportsPairforprovider.Pairsandprovider.Symmetricbefore callingAny()Written by Cursor Bugbot for commit 8ccbd67. This will update automatically on new commits. Configure here.