apply host performance timing limits to chrome call logging#457
Merged
bashbaug merged 3 commits intointel:mainfrom Mar 2, 2026
Merged
apply host performance timing limits to chrome call logging#457bashbaug merged 3 commits intointel:mainfrom
bashbaug merged 3 commits intointel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Applies host performance timing limits such as min/max enqueue counters and conditional controls to chrome call logging. This helps to keep chrome traces to a reasonable size, and even though this means that CallLogging and ChromeCallLogging may potentially log different numbers of API calls, it's perhaps not too strange, because ChromeCallLogging requires host performance times as part of the chrome trace and CallLogging does not.
Testing Done
Tested with a long running workload with many API calls. Prior to this change, the chrome trace file was multiple gigabytes, even with host performance timing controls set. After this change, the chrome trace file is much smaller, since it applies the host performance timing controls.