Skip to content

[libclc] build libclc as LLVM runtime#21221

Merged
sarnex merged 8 commits intointel:syclfrom
wenju-he:libclc-runtime-build
Feb 27, 2026
Merged

[libclc] build libclc as LLVM runtime#21221
sarnex merged 8 commits intointel:syclfrom
wenju-he:libclc-runtime-build

Conversation

@wenju-he
Copy link
Copy Markdown
Contributor

@wenju-he wenju-he commented Feb 5, 2026

Cherry-pick upstream commit a3a15f3 which moves libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES.

Update configure, build and deploy to enable libclc runtime build.
jira: CMPLRLLVM-73202

Upstream commit a3a15f3 moved libclc from LLVM_ALL_PROJECTS to
LLVM_DEFAULT_RUNTIMES.

libclc should be built as a runtime.
@wenju-he wenju-he marked this pull request as ready for review February 7, 2026 00:40
@wenju-he wenju-he requested review from a team and cperkinsintel as code owners February 7, 2026 00:40
@wenju-he wenju-he requested a review from bratpiorka February 7, 2026 00:40
@wenju-he
Copy link
Copy Markdown
Contributor Author

wenju-he commented Feb 7, 2026

BMG fail Failed Tests (1): SYCL :: Basic/parallel_for_range_roundup.cpp is known issue #20827

Comment thread buildbot/configure.py
cmake_cmd.extend(
[
"-DLLVM_ENABLE_RUNTIMES={}".format(llvm_enable_runtimes),
"-DLLVM_ENABLE_RUNTIMES={}".format(llvm_enable_runtimes.lstrip(";")),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Copy Markdown
Contributor Author

@wenju-he wenju-he Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM_ENABLE_RUNTIMES initial value is empty string, this change allows use appending LLVM_ENABLE_RUNTIMES with ";xxx" without the need to check if LLVM_ENABLE_RUNTIMES is empty, see 0753bc0

@wenju-he wenju-he requested a review from sarnex February 12, 2026 06:32
Copy link
Copy Markdown
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we technically should have the same lstrip on all appended variables but i think thats out of scope here, thx

@wenju-he
Copy link
Copy Markdown
Contributor Author

kindly ping @bratpiorka @intel/llvm-reviewers-cuda for review

@github-actions
Copy link
Copy Markdown
Contributor

@intel/llvm-gatekeepers please consider merging

@sarnex sarnex merged commit f3962f6 into intel:sycl Feb 27, 2026
31 checks passed
wenju-he added a commit that referenced this pull request Mar 1, 2026
@wenju-he wenju-he deleted the libclc-runtime-build branch March 2, 2026 00:58
sarnex pushed a commit that referenced this pull request Mar 2, 2026
Reverts #21221

libclc-remangler links against Clang/LLVM libraries built with the host
compiler, but the tool itself is built with the just-built Clang. This
causes an ABI issue around std::optional parameter in
MemoryBuffer::getFileOrSTDIN.
Jira: CMPLRLLVM-73868
wenju-he added a commit to wenju-he/llvm that referenced this pull request Mar 9, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from
LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES.

Update configure, build and deploy to enable libclc runtime build.
jira: CMPLRLLVM-73202

(cherry picked from commit f3962f6)

Also cherry-pick from intel#21403 to w/a libclc-remangler ABI mismatch on RHEL 8.

This PR is for sycl-web and I'll follow-up in sycl branch to remove
libclc-remangler tool.
wenju-he added a commit to wenju-he/llvm that referenced this pull request Mar 9, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from
LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES.

Update configure, build and deploy to enable libclc runtime build.
jira: CMPLRLLVM-73202

(cherry picked from commit f3962f6)

Also cherry-pick from intel#21403 to w/a libclc-remangler ABI mismatch on RHEL 8.

This PR is temporary fix to unblock sycl-web and I'll follow-up in sycl
branch to remove libclc-remangler tool.
sarnex pushed a commit that referenced this pull request Mar 10, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from
LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES.

Update configure, build and deploy to enable libclc runtime build. jira:
CMPLRLLVM-73202

(cherry picked from commit f3962f6)

Also cherry-pick from #21403 to w/a libclc-remangler ABI mismatch on
RHEL 8.

This PR is temporary fix to unblock sycl-web and I'll follow-up in sycl
branch to remove libclc-remangler tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants