[libclc] build libclc as LLVM runtime#21221
Merged
sarnex merged 8 commits intointel:syclfrom Feb 27, 2026
Merged
Conversation
Upstream commit a3a15f3 moved libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES. libclc should be built as a runtime.
Contributor
Author
|
BMG fail |
sarnex
reviewed
Feb 9, 2026
| cmake_cmd.extend( | ||
| [ | ||
| "-DLLVM_ENABLE_RUNTIMES={}".format(llvm_enable_runtimes), | ||
| "-DLLVM_ENABLE_RUNTIMES={}".format(llvm_enable_runtimes.lstrip(";")), |
Contributor
Author
There was a problem hiding this comment.
LLVM_ENABLE_RUNTIMES initial value is empty string, this change allows use appending LLVM_ENABLE_RUNTIMES with ";xxx" without the need to check if LLVM_ENABLE_RUNTIMES is empty, see 0753bc0
sarnex
approved these changes
Feb 12, 2026
Contributor
sarnex
left a comment
There was a problem hiding this comment.
probably we technically should have the same lstrip on all appended variables but i think thats out of scope here, thx
Contributor
Author
|
kindly ping @bratpiorka @intel/llvm-reviewers-cuda for review |
bratpiorka
approved these changes
Feb 27, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
sarnex
pushed a commit
that referenced
this pull request
Mar 2, 2026
Reverts #21221 libclc-remangler links against Clang/LLVM libraries built with the host compiler, but the tool itself is built with the just-built Clang. This causes an ABI issue around std::optional parameter in MemoryBuffer::getFileOrSTDIN. Jira: CMPLRLLVM-73868
wenju-he
added a commit
to wenju-he/llvm
that referenced
this pull request
Mar 9, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES. Update configure, build and deploy to enable libclc runtime build. jira: CMPLRLLVM-73202 (cherry picked from commit f3962f6) Also cherry-pick from intel#21403 to w/a libclc-remangler ABI mismatch on RHEL 8. This PR is for sycl-web and I'll follow-up in sycl branch to remove libclc-remangler tool.
wenju-he
added a commit
to wenju-he/llvm
that referenced
this pull request
Mar 9, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES. Update configure, build and deploy to enable libclc runtime build. jira: CMPLRLLVM-73202 (cherry picked from commit f3962f6) Also cherry-pick from intel#21403 to w/a libclc-remangler ABI mismatch on RHEL 8. This PR is temporary fix to unblock sycl-web and I'll follow-up in sycl branch to remove libclc-remangler tool.
sarnex
pushed a commit
that referenced
this pull request
Mar 10, 2026
Cherry-pick upstream commit a3a15f3 which moves libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES. Update configure, build and deploy to enable libclc runtime build. jira: CMPLRLLVM-73202 (cherry picked from commit f3962f6) Also cherry-pick from #21403 to w/a libclc-remangler ABI mismatch on RHEL 8. This PR is temporary fix to unblock sycl-web and I'll follow-up in sycl branch to remove libclc-remangler tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick upstream commit a3a15f3 which moves libclc from LLVM_ALL_PROJECTS to LLVM_DEFAULT_RUNTIMES.
Update configure, build and deploy to enable libclc runtime build.
jira: CMPLRLLVM-73202