Fix compatibility with QGS for boost 1.87 and 1.89 API changes #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asio::io_service type was deprecated since 1.66 in 2017, with asio::io_context being its drop-in replacement. Release 1.87 finally dropped the back-compat support for asio::io_service entirely. To retain compat with old boost this change conditionally re-adds the compat definition for asio::io_service. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
The asio::deadline_timer was deprecated in 1.89 and as a result the deadline_timer.hpp file is no longer implicitly included by asio.hpp. To retain compat with old and new boost the code must explicitly include the deadline_timer.hpp Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In boost 1.87 the (long deprecated)
asio::io_servicetype was dropped. To fix this, re-add the compat typedef in qgs codeIn boost 1.87 the asio::deadline_timer type was deprecated. To fix this add an explicit #include of the deadline_timer header.
This should retain compat with both old and new Boost versions