fix: In Linux CL/GL sharing, handle failed symbols lookup#808
Open
smunaut wants to merge 1 commit intointel:masterfrom
Open
fix: In Linux CL/GL sharing, handle failed symbols lookup#808smunaut wants to merge 1 commit intointel:masterfrom
smunaut wants to merge 1 commit intointel:masterfrom
Conversation
Contributor
JablonskiMateusz
left a comment
There was a problem hiding this comment.
please update years in copyright headers
960e818 to
6b61230
Compare
In some cases we endup with GL being found but neither GLX or EGL found and this currently leads to crash. So to better handle this case (and others), we keep track if we found symbols or not. If we're asked if CL/GL sharing is supported we check the load worked. If it's during an actual context creation we check what we were given match what we could load and fail context property finalization if not. If it's during an "info" request where we don't have any properties yet, we return yes if either GLX or EGL was found. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Contributor
Author
|
Done |
Contributor
|
please correct tests as well, as currently there is unit test failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we endup with GL being found but neither GLX or EGL found and this currently leads to crash.
So to better handle this case (and others), we keep track if we found symbols or not.
If we're asked if CL/GL sharing is supported we check the load worked.
If it's during an actual context creation we check what we were given match what we could load and fail context property finalization if not.
If it's during an "info" request where we don't have any properties yet, we return yes if either GLX or EGL was found.