Skip to content

Fix leanvec ood for public-only build and update binaries #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanglaser merged 5 commits into from
Mar 16, 2026
Merged

Fix leanvec ood for public-only build and update binaries #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dec519a
Use lto ivf nightly shared library build for runtime bindings
ethanglaser Mar 16, 2026
6d2363d
Update runtime bindings and shared examples to use v0.2.0 libs
ethanglaser Mar 16, 2026
13fa899
Trying latest nightly
ethanglaser Mar 16, 2026
46ffacf
Revert last and update training.cpp
ethanglaser Mar 16, 2026
fb72a58
Don't cancel cpp runtime tests just because one fails
ethanglaser Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-cpp-runtime-bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ jobs:
- name: "IVF public only"
suffix: "-ivf"
enable_ivf: "ON"
fail-fast: false

steps:
- uses: actions/checkout@v6
Expand Down
4 changes: 2 additions & 2 deletions bindings/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,14 @@ if (SVS_RUNTIME_ENABLE_LVQ_LEANVEC)
else()
# Links to LTO-enabled static library, requires GCC/G++ 11.2
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.2" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.3")
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-lto-nightly-2026-02-05-1017.tar.gz"
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0-lto-ivf.tar.gz"
CACHE STRING "URL to download SVS shared library")
else()
message(WARNING
"Pre-built LVQ/LeanVec SVS library requires GCC/G++ v.11.2 to apply LTO optimizations."
"Current compiler: ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}"
)
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/nightly/svs-shared-library-nightly-2026-02-05-1017.tar.gz"
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0-ivf.tar.gz"
CACHE STRING "URL to download SVS shared library")
endif()
include(FetchContent)
Expand Down
14 changes: 14 additions & 0 deletions bindings/cpp/src/training.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,20 @@ Status LeanVecTrainingData::build(
"LeanVecTrainingData is not supported in this build configuration."
);
}
Status LeanVecTrainingData::build(
LeanVecTrainingData** SVS_UNUSED(training_data),
size_t SVS_UNUSED(dim),
size_t SVS_UNUSED(n),
const float* SVS_UNUSED(x),
size_t SVS_UNUSED(n_q),
const float* SVS_UNUSED(x_q),
size_t SVS_UNUSED(leanvec_dims)
) noexcept {
return Status(
ErrorCode::NOT_IMPLEMENTED,
"LeanVecTrainingData is not supported in this build configuration."
);
}
Status LeanVecTrainingData::destroy(LeanVecTrainingData* SVS_UNUSED(training_data)
) noexcept {
return Status(
Expand Down
2 changes: 1 addition & 1 deletion examples/cpp/shared/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ find_package(svs QUIET)
if(NOT svs_FOUND)
# If sourcing from pip/conda, the following steps are not necessary, simplifying workflow
# If not found, download tarball from GitHub release and follow steps to fetch and find
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.1.0/svs-shared-library-0.1.0.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system")
set(SVS_URL "https://github.com/intel/ScalableVectorSearch/releases/download/v0.2.0/svs-shared-library-0.2.0.tar.gz" CACHE STRINGS "URL to download SVS shared library tarball if not found in system")

message(STATUS "SVS not found in system, downloading from: ${SVS_URL}")

Expand Down
Loading