Native serialization for MultiMutableVamana index#289
Draft
razdoburdin wants to merge 2 commits intointel:dev/razdoburdin_streamingfrom
Draft
Native serialization for MultiMutableVamana index#289razdoburdin wants to merge 2 commits intointel:dev/razdoburdin_streamingfrom
razdoburdin wants to merge 2 commits intointel:dev/razdoburdin_streamingfrom
Conversation
razdoburdin
requested review from
ahuber21,
ibhati,
mihaic and
yuejiaointel
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce native serialization for
MultiMutableVamanaindex.Should be merged after: #286
Main changes are:
svs::index::vamana::auto_multi_dynamic_assemblerequired for direct deserialization accepts lazy loaders and call them in a flexible order to cover legacy serialized models.supports_savingflag is keeped false, as far as it isn't used.MultiMutableVamanadoesn't have an orchestrator. So no changes on this side.