feat: Add github_team_external_groups data source#3296
feat: Add github_team_external_groups data source#3296orirawlings wants to merge 1 commit intointegrations:mainfrom
github_team_external_groups data source#3296Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Partial review, left a few change requests :)
orirawlings
force-pushed
the
team_external_groups
branch
2 times, most recently
from
c0057e8 to
b5ae884
Compare
|
Thank you very much for the partial review @deiga! I went ahead and addressed the feedback. Let me know if anything looks off. This is my first time working on terraform provider code so I'm still ramping up on the testing framework/approach. Cheers |
| ___ | ||
|
|
||
| * `group_id` - The ID of the external group. | ||
| * `group_name` - The name of the external group. | ||
| * `updated_at` - The date the group was last updated. |
There was a problem hiding this comment.
issue: This doesn't follow the pattern in the docs, please adjust
There was a problem hiding this comment.
I assume you prefer the subfields to be a nested list under external_groups? The current patch is replicating the pattern used in website/docs/d/external_groups.html.markdown. Should I include a commit to update to use a nested list there as well?
There was a problem hiding this comment.
@deiga Thanks for another round of review.
I went ahead and pushed an update to both pages to use a nested list. I also realized I missed adding a link to the new page in website/github.erb, so I added that as well.
orirawlings
force-pushed
the
team_external_groups
branch
from
b5ae884 to
27f3db1
Compare
|
Thank you for the review and approval @deiga! |
2 participants
Resolves #3295
Before the change?
After the change?
github_team_external_groupsdata source for loading the external groups mapped to a given team.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!