Swap GitHub and Terrform logos depending on light or dark mode#3264
Open
thekbb wants to merge 1 commit intointegrations:mainfrom
Open
Swap GitHub and Terrform logos depending on light or dark mode#3264thekbb wants to merge 1 commit intointegrations:mainfrom
thekbb wants to merge 1 commit intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3263
Before the change?
When using GitHub's dark theme, the GitHub and Terraform logos are difficult to read:
After the change?
The Readme uses the picture element, which is supported in GitHub markdown, to swap out the assets depending on current theme.
The default is light mode.
Light theme:
Dark theme:
I added the svg assets to
readme-assets/, as well as slightly decreasing the size (height 50px, rather than 70px), and centered rather then left justified.The markdownlint.yaml file has a rule against in-line-html enabled. I've disabled it for the section I've added.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!