fix: use getBaseURL in acc_test.go to match provider URL parsing#3258
Open
amreshh wants to merge 1 commit intointegrations:mainfrom
Open
fix: use getBaseURL in acc_test.go to match provider URL parsing#3258amreshh wants to merge 1 commit intointegrations:mainfrom
amreshh wants to merge 1 commit intointegrations:mainfrom
Conversation
acc_test.go was parsing GITHUB_BASE_URL with url.Parse() directly, bypassing the normalization done by getBaseURL() in the provider. This caused the test base URL to differ from what the provider produces (e.g. missing trailing slash, no github.com → api.github.com rewrite, no ghe.com API host prefix). Additionally, IsGHES was never set on the test Config, so GHES-specific behavior was not exercised in tests.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
deiga
approved these changes
Mar 5, 2026
Collaborator
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Yay! Thanks! @stevehipwell, you're up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3256
Before the change?
acc_test.go was parsing GITHUB_BASE_URL with url.Parse() directly, bypassing the normalization done by getBaseURL() in the provider. This caused the test base URL to differ from what the provider produces (e.g. missing trailing slash, no github.com → api.github.com rewrite, no ghe.com API host prefix). Additionally, IsGHES was never set on the test Config, so GHES-specific behavior was not exercised in tests.
After the change?
Now acc_test.go is calling getBaseURL() as provider.go is doing so the base url is parsed in the same way. Test cases on GHES now run correctly.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!